-
Notifications
You must be signed in to change notification settings - Fork 185
[build-tools] report app and build version from final archive #3499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kadikraman
wants to merge
8
commits into
main
Choose a base branch
from
kadikraman/report-actual-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
636ec73
Add function to report resolved version
kadikraman 132e8bf
Add tests for the parser functions
kadikraman db7f29f
Format
kadikraman 02b6eca
Use fast-xml-parser
kadikraman ac9b5b5
Read archive path from previous step
kadikraman 63e1ce2
Also report app versions in builder files
kadikraman 7944f61
Format
kadikraman 3e90915
Add tests for the extract functions
kadikraman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,10 @@ import { runFastlaneGym, runFastlaneResign } from '../ios/fastlane'; | |
| import { installPods } from '../ios/pod'; | ||
| import { downloadApplicationArchiveAsync } from '../ios/resign'; | ||
| import { resolveArtifactPath, resolveBuildConfiguration, resolveScheme } from '../ios/resolve'; | ||
| import { | ||
| extractIosVersionAsync, | ||
| reportResolvedVersionAsync, | ||
| } from '../steps/functions/reportResolvedVersion'; | ||
| import { cacheStatsAsync, restoreCcacheAsync } from '../steps/functions/restoreBuildCache'; | ||
| import { saveCcacheAsync } from '../steps/functions/saveBuildCache'; | ||
| import { uploadApplicationArchive } from '../utils/artifacts'; | ||
|
|
@@ -175,14 +179,32 @@ async function buildAsync(ctx: BuildContext<Ios.Job>): Promise<void> { | |
| await runHookIfPresent(ctx, Hook.PRE_UPLOAD_ARTIFACTS); | ||
| }); | ||
|
|
||
| await ctx.runBuildPhase(BuildPhase.UPLOAD_APPLICATION_ARCHIVE, async () => { | ||
| await uploadApplicationArchive(ctx, { | ||
| const archivePath = await ctx.runBuildPhase(BuildPhase.UPLOAD_APPLICATION_ARCHIVE, async () => { | ||
| return await uploadApplicationArchive(ctx, { | ||
| patternOrPath: resolveArtifactPath(ctx), | ||
| rootDir: ctx.getReactNativeProjectDirectory(), | ||
| logger: ctx.logger, | ||
| }); | ||
| }); | ||
|
|
||
| if (archivePath) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need it to be inside a build phase, otherwise if the users are oging to see "Unnamed build phase" logs which I've seen people complain about before. Maybe we can move it inside upload application archive? |
||
| try { | ||
| const { appVersion, appBuildVersion } = await extractIosVersionAsync(archivePath); | ||
| const buildId = ctx.env.EAS_BUILD_ID; | ||
| if (buildId && (appVersion || appBuildVersion)) { | ||
| await reportResolvedVersionAsync(ctx.graphqlClient, buildId, { | ||
| appVersion, | ||
| appBuildVersion, | ||
| }); | ||
| ctx.logger.info( | ||
| `Reported resolved version: ${appVersion ?? 'N/A'} (${appBuildVersion ?? 'N/A'})` | ||
| ); | ||
| } | ||
| } catch (err) { | ||
| ctx.logger.warn({ err }, 'Failed to report resolved version (non-fatal)'); | ||
| } | ||
| } | ||
|
|
||
| await ctx.runBuildPhase(BuildPhase.SAVE_CACHE, async () => { | ||
| if (ctx.isLocal) { | ||
| ctx.logger.info('Local builds do not support saving cache.'); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same