Coderabbit integration and danger file update to include all 40 rules#348
Coderabbit integration and danger file update to include all 40 rules#348bittubharadwaj wants to merge 5 commits into
Conversation
Replaced code-climate upload step with qlty upload step for code coverage reports.
…moke-test Add CodeRabbit configuration
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR introduces CodeRabbit configuration/documentation and expands the repository’s automated PR policy checks by replacing the minimal Dangerfile with a larger “legacy Expertiza” rule set, plus adjusts CI coverage publishing.
Changes:
- Replace
Dangerfilewith an expanded ruleset (size/scope checks, test hygiene checks, sensitive-file guardrails, etc.). - Add CodeRabbit configuration and a repository-specific CodeRabbit guideline document.
- Update CI to publish coverage via a Qlty GitHub Action and adjust the PR comment workflow.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Dangerfile |
Replaces the prior lightweight checks with a comprehensive Expertiza-style PR policy ruleset. |
CODERABBIT_GUIDELINES.md |
Adds repo-specific guidance for CodeRabbit reviews and policy mirroring. |
.github/workflows/main.yml |
Switches coverage upload step from Code Climate to Qlty action using coverage/coverage.json. |
.github/workflows/CommentPR.yml |
Modifies how the PR comment workflow sets/passes GITHUB_TOKEN. |
.coderabbit.yaml |
Adds CodeRabbit configuration (review behavior, path instructions, pre-merge checks, tool toggles). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return if CURRENT_MAINTAINERS.include?(PR_AUTHOR) | ||
| return unless TOUCHED_FILES.grep(regex).any? | ||
|
|
||
| fail("You changed #{filename}; please double-check whether this is necessary.", sticky: true) |
| if TOUCHED_FILES.grep(%r{^app/}).any? && TOUCHED_FILES.grep(%r{^spec/}).empty? | ||
| warn( | ||
| markdown( | ||
| <<~MARKDOWN | ||
| There are code changes, but no corresponding tests. | ||
| Please include tests if this PR introduces any modifications in behavior. | ||
| MARKDOWN | ||
| ), | ||
| sticky: true | ||
| ) | ||
| end |
| message: | | ||
| 🚨 **RSpec Tests Report** | ||
| ``` | ||
| ${{ steps.read_files.outputs.test_output }} | ||
| ``` | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
No description provided.