Skip to content

comments for cars-assemble analyzer #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# avoid using return in else statement
When an `if` block ends with a return statement, the subsequent `else` is redundant.
Removing the `else` can make the code cleaner and easier to read.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# prefer storing constant in field
The value 221 is a magic number: a hard-coded constant without explanation.
To improve readability and maintainability, replace repeated or unexplained values with a named constant.