Fix stale popup data when reopening a module popup#2988
Open
eyupcanakman wants to merge 1 commit intoexelban:masterfrom
Open
Fix stale popup data when reopening a module popup#2988eyupcanakman wants to merge 1 commit intoexelban:masterfrom
eyupcanakman wants to merge 1 commit intoexelban:masterfrom
Conversation
jestfortest
approved these changes
Feb 28, 2026
Prime popup and sleep readers on popup reopen so higher update intervals don't leave stale numbers visible until the next tick.
eyupcanakman
changed the title
eyupcanakman
force-pushed
the
fix/popup-refresh-on-open-2140
branch
from
ac66b1a to
f33e4d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2140.
Summary
High update intervals leave popup values stale on reopen.
Reader.start()only primes a fresh read during initial setup, so when a popup reader pauses on close and is restarted on open, it waits for the next scheduled tick before showing current data. Add a branch that dispatches a background read when a popup or sleep reader reopens while inactive.Testing
xcodebuild -project Stats.xcodeproj -scheme Stats -destination 'platform=macOS' -configuration Release archive CODE_SIGNING_ALLOWED=NO