Skip to content

Feature/interval ratio 3digit precision #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bishibashiB wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/interval ratio 3digit precision #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70336ae
remove twice applying interval_ratio for odd number of tabs
bishibashiB Nov 21, 2021
678a792
allow 3 digits precision for intervall_ratio
bishibashiB Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lasercut/join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def get_slot_positions(tab_properties):
if tab_properties.tabs_number % 2 == 1:
slots_list.append(0.0 + tab_properties.tabs_shift)
for i in range(half_tab_number):
left = float(i+1) * interval_length * tab_properties.interval_ratio
right = float(-i-1) * interval_length * tab_properties.interval_ratio
left = float(i+1) * interval_length
right = float(-i-1) * interval_length
if tab_properties.interval_ratio != 1.0:
left *= tab_properties.interval_ratio
right *= tab_properties.interval_ratio
Expand Down
2 changes: 1 addition & 1 deletion panel/tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def __init__(self, tab_properties):
WidgetValue(type=float, name="tabs_shift", show_name="Shift", widget=None,
interval_value=[-300, 300.], step=1., decimals=2),
WidgetValue(type=float, name="interval_ratio", show_name="Interval ratio",
widget=None, interval_value=[0.1, 5.], step=0.1, decimals=2),
widget=None, interval_value=[0.1, 5.], step=0.1, decimals=3),
WidgetValue(type=bool, name="dog_bone", show_name="Dog bone hole", widget=None),
WidgetValue(type=bool, name="tab_dog_bone", show_name="Tab dog bone hole", widget=None)
])
Expand Down