fix: Tracer.logConnectionDetails defaults to true#80
Open
trygve-baerland wants to merge 8 commits into
Open
Conversation
The golang.org/x/lint/golint tool was archived in 2020. Replace the Makefile's `lint` target with `golangci-lint run ./...` and drop the now-unused `deps` target that installed the archived binary. CI gains a `golangci-lint` step using golangci/golangci-lint-action@v9 so the same check runs in pull requests.
Define an unexported spanNameCtxKey struct in
TestTracer_sqlOperationNameFromCtx instead of using a bare string
as the context.WithValue key. Mirrors the startTimeCtxKey{} pattern
already used in tracer.go and silences staticcheck SA1029.
Author
Member
|
Oh boy, thanks for catching this (again). Could you potentially rebase your PR onto #79 and refactor the tests to use testify? I expect 79 to land soon and will merge yours right after. Thank you! |
Author
|
No problem, @obitech, I can do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my understanding, the
Tracer.logConnectionDetailsis meant to default totrue(going by how the config struct is initialized inNewTracer), and usingWithDisableConnectionDetailsInAttributesto set it tofalse.This PR is a fix so the tracer behaves as described above.
I've also added a table of tests making assertions about what attributes are present in traces under different configurations. Since these tests set up a mock pg connection, the changes to tests are quite verbose. I'll be more than happy to get any suggestions on better ways of testing the attributes behaviour (or any other suggestions, for that matter).