-
Notifications
You must be signed in to change notification settings - Fork 57
Revert "ci: update preview trigger to pull_request_target to enable previews for forks" #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…reviews …" This reverts commit 3b5831a.
WalkthroughThe workflow configuration in the GitHub repository has been modified to trigger on the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/preview.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/preview.yml (1)
4-4
: Change frompull_request_target
topull_request
is appropriate for security.This change enhances security by ensuring that workflows run with the permissions of the pull request's author, not with broader repository write access, which is crucial especially for public repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/preview.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/preview.yml
Reverts #393
Added comment for future reference.
You can also see that the CI now passes again
Summary by CodeRabbit
pull_request_target
topull_request
to improve the timing of workflow executions.