Skip to content

fix(obs-obsidian): corrige schema de filtro and/or/not + documenta embed de Bases#122

Open
mt-alarcon wants to merge 1 commit into
evolution-foundation:developfrom
mt-alarcon:pr/obs-obsidian-filter-schema
Open

fix(obs-obsidian): corrige schema de filtro and/or/not + documenta embed de Bases#122
mt-alarcon wants to merge 1 commit into
evolution-foundation:developfrom
mt-alarcon:pr/obs-obsidian-filter-schema

Conversation

@mt-alarcon

@mt-alarcon mt-alarcon commented Jul 16, 2026

Copy link
Copy Markdown

Corrige o schema de filtro (and/or/not) na skill obs-obsidian-bases e documenta o embed de Bases (.base) em obs-obsidian-markdown/references/EMBEDS.md.

Fix genérico de skill — beneficia qualquer usuário do EvoNexus com Obsidian.

🤖 Generated with Claude Code

Summary by Sourcery

Documentation:

  • Document usage of Base file embeds and specific view embeds in Obsidian markdown references.

@sourcery-ai

sourcery-ai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the obs-obsidian-bases skill filter schema examples to demonstrate correct recursive and/or/not usage with concrete filters, and documents how to embed .base files and specific views in Obsidian markdown.

File-Level Changes

Change Details Files
Update the obs-obsidian-bases skill documentation to show a valid recursive filter object schema using and/or/not with concrete examples for global and view-specific filters.
  • Clarify that the filters section can be either a single filter string or a recursive filter object with exactly one of the keys and, or, or not at each level.
  • Replace empty and/or/not arrays in the global filters example with a concrete and filter combining a status condition and a nested not filter based on tags.
  • Align the views.filters example with the updated schema by replacing the empty and array with a concrete status filter and noting that view-specific filters follow the same rules as global filters.
.claude/skills/obs-obsidian-bases/SKILL.md
Document how to embed Base (.base) files and their views within Obsidian markdown.
  • Add a new 'Embed Bases' section to the embeds reference documentation.
  • Provide markdown examples for embedding an entire .base file and a specific view within a .base file using Obsidian link syntax.
.claude/skills/obs-obsidian-markdown/references/EMBEDS.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The updated filter example under filters now shows a concrete and/not structure; consider explicitly labeling it as an example (rather than implied default) to avoid users assuming these filters are required.
  • You state that recursive filter objects must have exactly one key (and, or, or not), but the view-specific filters example only demonstrates and; adding a brief inline note or example for or and not at the view level would make the rule clearer.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The updated filter example under `filters` now shows a concrete `and/not` structure; consider explicitly labeling it as an example (rather than implied default) to avoid users assuming these filters are required.
- You state that recursive filter objects must have exactly one key (`and`, `or`, or `not`), but the view-specific filters example only demonstrates `and`; adding a brief inline note or example for `or` and `not` at the view level would make the rule clearer.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mt-alarcon

Copy link
Copy Markdown
Author

Two small doc fixes for the Obsidian skills.

The filter-schema example in obs-obsidian-bases/SKILL.md had and: [], or: [] and not: [] sitting next to each other, which makes it look like you can combine all three in one object. You can't — a Bases filter object takes a single key, nested recursively. I rewrote the example to show that, with an and list wrapping a nested not.

I also added an "Embed Bases" section to references/EMBEDS.md (![[BaseFile.base]] and ![[BaseFile.base#View Name]]) — it was the one embed type missing from that page.

No behavior change, just docs. Let me know if you'd word it differently.

…bed de Bases

filters aceita EXATAMENTE uma chave (and/or/not), não as três vazias juntas
(obs-obsidian-bases/SKILL.md); embed de arquivo .base via ![[Base.base]] e
![[Base.base#View]] estava ausente (obs-obsidian-markdown/EMBEDS.md).
Diff vs upstream revisado 13/07 — candidato a PR.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015fwjHYV75fTwTH8c5YxR2g
@mt-alarcon
mt-alarcon force-pushed the pr/obs-obsidian-filter-schema branch from 4232ac1 to 0fb30ca Compare July 16, 2026 02:28
@mt-alarcon
mt-alarcon changed the base branch from main to develop July 16, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant