fix(obs-obsidian): corrige schema de filtro and/or/not + documenta embed de Bases#122
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the obs-obsidian-bases skill filter schema examples to demonstrate correct recursive and/or/not usage with concrete filters, and documents how to embed .base files and specific views in Obsidian markdown. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The updated filter example under
filtersnow shows a concreteand/notstructure; consider explicitly labeling it as an example (rather than implied default) to avoid users assuming these filters are required. - You state that recursive filter objects must have exactly one key (
and,or, ornot), but the view-specific filters example only demonstratesand; adding a brief inline note or example fororandnotat the view level would make the rule clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated filter example under `filters` now shows a concrete `and/not` structure; consider explicitly labeling it as an example (rather than implied default) to avoid users assuming these filters are required.
- You state that recursive filter objects must have exactly one key (`and`, `or`, or `not`), but the view-specific filters example only demonstrates `and`; adding a brief inline note or example for `or` and `not` at the view level would make the rule clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Two small doc fixes for the Obsidian skills. The filter-schema example in I also added an "Embed Bases" section to No behavior change, just docs. Let me know if you'd word it differently. |
…bed de Bases filters aceita EXATAMENTE uma chave (and/or/not), não as três vazias juntas (obs-obsidian-bases/SKILL.md); embed de arquivo .base via ![[Base.base]] e ![[Base.base#View]] estava ausente (obs-obsidian-markdown/EMBEDS.md). Diff vs upstream revisado 13/07 — candidato a PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015fwjHYV75fTwTH8c5YxR2g
4232ac1 to
0fb30ca
Compare
Corrige o schema de filtro (
and/or/not) na skill obs-obsidian-bases e documenta o embed de Bases (.base) em obs-obsidian-markdown/references/EMBEDS.md.Fix genérico de skill — beneficia qualquer usuário do EvoNexus com Obsidian.
🤖 Generated with Claude Code
Summary by Sourcery
Documentation: