fix(fetchers): enforce docs site outbound policy#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enforce FetchKit's outbound policy for
DocsSiteFetcher, covering directllms.txtrequests, llms probe requests, and docs-page fetches.Closes #94.
Why
DocsSiteFetcherused its own redirect-following client, which bypassed DNS pinning, private-IP blocking, and manual redirect validation. That let docs andllms.txtrequests ignore the default SSRF posture.How
llms.txtfetches through the shared hardened request helperllms-full.txt/llms.txtprobes and fallback docs-page fetches through the same transport pathllms.txtfetches andlocalhost -> 127.0.0.1redirect enforcementRisk
Checklist