fix(ci): isolate coreutils drift external execution#1614
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 72ea87e | Commit Preview URL | May 08 2026, 08:14 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split the coreutils drift workflow so uutils checkout/build/differential execution runs only in a read-only job without persisted checkout credentials.
Why
The previous drift path executed third-party Rust build scripts and the generated uutils binary inside a job with repository and PR write scopes. That let a compromised upstream or dependency abuse privileged CI credentials.
How
contents: readwithpersist-credentials: falseon both checkouts.crates/bashkit/src/builtins/generated/.gh.Risk
ghPR update path behaves differently from the previous action.Checklist
Verified:
cargo test -p bashkit --test workflow_security_testsbefore the workflow split.cargo test -p bashkit --test workflow_security_testscargo fmt --checkcargo clippy --all-targets -- -D warningscargo testcargo vet.github/workflows/coreutils-args-drift.yml