fix(ci): sandbox coreutils drift generation#1611
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 5bb0602 | Commit Preview URL | May 08 2026, 07:57 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens the coreutils argument-drift path so third-party generated Rust is not executed with repository write credentials.
Why
The weekly/manual drift workflow consumes
uutils/coreutils, generates Rust fromuu_app(), then builds and tests bashkit. A malicious upstreamuu_app()could previously preserve executable statements in generated command builders and run them in a job withcontents: writeandpull-requests: write.How
bashkit-coreutils-portsouu_app()must be a single clapCommand::new(...)builder chain and rejects executable prefix statements/block control flow before emission..github/workflows/coreutils-args-drift.ymlinto read-only regeneration/test and write-scoped PR creation jobs; read-only checkouts disable persisted credentials.Risk
uu_app()shapes that are not simple builder chains will fail codegen and require an explicit generator update instead of silently emitting executable Rust.Checklist
Verified:
cargo test -p bashkit-coreutils-portcargo test -p bashkit --test spec_tests bash_spec_testsruby -e 'require "yaml"; YAML.load_file(".github/workflows/coreutils-args-drift.yml"); puts "ok"'git diff --checkjust pre-pr