Allow offhand buckets, fix client desync when events are cancelled....#35
Open
ThatPotatoDev wants to merge 2 commits intoeverbuild-org:devfrom
Open
Allow offhand buckets, fix client desync when events are cancelled....#35ThatPotatoDev wants to merge 2 commits intoeverbuild-org:devfrom
ThatPotatoDev wants to merge 2 commits intoeverbuild-org:devfrom
Conversation
…dd FluidPlaceEvent.kt
Bloeckchengrafik
requested changes
Aug 27, 2025
Member
Bloeckchengrafik
left a comment
Bloeckchengrafik
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
...uff-fluids/src/main/kotlin/org/everbuild/blocksandstuff/fluids/pickup/FluidPickupListener.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+115
to
+138
| fun isWaterloggable(block: Block): Boolean { | ||
| val tags = Block.staticRegistry() | ||
| return (tags.getTag(Key.key("minecraft:stairs"))!!.contains(block) | ||
| || tags.getTag(Key.key("minecraft:slabs"))!!.contains(block) | ||
| || tags.getTag(Key.key("minecraft:fences"))!!.contains(block) | ||
| || tags.getTag(Key.key("minecraft:trapdoors"))!!.contains(block)) | ||
| // if (block.compare(Block.LADDER) | ||
| // || block.compare(Block.SUGAR_CANE) | ||
| // || block.compare(Block.BUBBLE_COLUMN) | ||
| // || block.compare(Block.NETHER_PORTAL) | ||
| // || block.compare(Block.END_PORTAL) | ||
| // || block.compare(Block.END_GATEWAY) | ||
| // || block.compare(Block.KELP) | ||
| // || block.compare(Block.KELP_PLANT) | ||
| // || block.compare(Block.SEAGRASS) | ||
| // || block.compare(Block.TALL_SEAGRASS) | ||
| // || block.compare(Block.SEA_PICKLE) | ||
| // || tags.getTag(Tag.BasicType.BLOCKS, "minecraft:signs")!!.contains(block.namespace()) | ||
| // || block.name().contains("door") | ||
| // || block.name().contains("coral") | ||
| // if (tags.getTag(Key.key("minecraft:stairs"))!!.contains(block)) { | ||
| // return true | ||
| // } | ||
| // return !block.isSolid || !block.isAir |
Member
There was a problem hiding this comment.
I think a custom tag would fit better here, so all blocks stay supported and the logic is cleaner. (RegistryTag#direct)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow offhand buckets, fix client desync when events are cancelled, add FluidPlaceEvent, and some code cleanup