-
Notifications
You must be signed in to change notification settings - Fork 987
chore(deps): upgrade Nx to 23.1.0, TypeScript to 6.0.3, and align package versions #9934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
5b38124
882f4de
f2da543
b9b0122
98c92e2
cf09c29
c8eb9c8
57e58ce
ff85b18
6e0410b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -160,3 +160,5 @@ apps/server-api/src/assets/icons/menu | |
| !**/certs/**/.gitkeep | ||
|
|
||
| /Tempnx-console-tmp**/** | ||
|
|
||
| .claude/worktrees | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,4 +7,5 @@ | |
| .angular | ||
|
|
||
| /.nx/cache | ||
| /.nx/workspace-data | ||
| /.nx/workspace-data | ||
| .nx/self-healing | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,18 +180,18 @@ | |
| "@types/yargs": "^15.0.9", | ||
| "jasmine-core": "^3.6.0", | ||
| "jasmine-spec-reporter": "^6.0.0", | ||
| "jest": "30.0.0", | ||
| "jest": "30.3.0", | ||
| "jest-preset-angular": "16.0.0", | ||
| "karma": "^6.4.4", | ||
| "karma-chrome-launcher": "^3.2.0", | ||
| "karma-cli": "^2.0.0", | ||
| "karma-coverage-istanbul-reporter": "^3.0.3", | ||
| "karma-jasmine": "^5.1.0", | ||
| "karma-jasmine-html-reporter": "^1.5.4", | ||
| "karma-jasmine-html-reporter": "^1.7.0", | ||
| "terser": "^5.30.3", | ||
| "terser-webpack-plugin": "^5.3.16", | ||
| "webpack": "5.104.1", | ||
| "webpack-cli": "^6.0.1", | ||
| "webpack": "5.108.4", | ||
| "webpack-cli": "7.2.1", | ||
|
Comment on lines
+193
to
+194
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
python - <<'PY'
import json
from pathlib import Path
manifest = json.loads(Path("apps/gauzy/package.json").read_text())
for name in ("webpack", "webpack-cli"):
print(
name,
"direct=", manifest["devDependencies"].get(name),
"local_resolution=", manifest.get("resolutions", {}).get(name),
)
PY
rg -n -C 3 '"resolutions"|"webpack"|"webpack-cli"' package.json apps/gauzy/package.json
rg -n -C 2 '^(webpack|webpack-cli)@' yarn.lockRepository: ever-co/ever-gauzy Length of output: 3404 🏁 Script executed: #!/bin/bash
set -euo pipefail
python3 - <<'PY'
import json
from pathlib import Path
root = json.loads(Path("package.json").read_text())
gauzy = json.loads(Path("apps/gauzy/package.json").read_text())
for name in ("webpack", "webpack-cli"):
root_res = root.get("resolutions", {}).get(name)
gauzy_dep = gauzy.get("devDependencies", {}).get(name)
gauzy_res = gauzy.get("resolutions", {}).get(name)
gauge_cli_dep = gauzy.get("dependencies", {}).get(name)
print(f"{name}:")
print(f" root manifest resolutions={root_res!r}")
print(f" apps/gauzy devDependencies={gauzy_dep!r}")
print(f" apps/gauzy dependencies={gauge_cli_dep!r}")
print(f" apps/gauzy resolutions={gauzy_res!r}")
lock_text = Path("yarn.lock").read_text()
for name in ("webpack-cli@7.2.1:", "webpack@5.108.4:", "webpack@5.104.1, webpack@^5, webpack@^5.80.0, webpack@^5.88.0:", "webpack-cli@^6.0.1:"):
idx = lock_text.find(name)
print(f"\nLock entry {name!r} present={idx != -1}")
PYRepository: ever-co/ever-gauzy Length of output: 679 Remove the stale
🤖 Prompt for AI Agents |
||
| "webpack-merge": "^6.0.1", | ||
| "webpack-node-externals": "^3.0.0" | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -153,6 +153,7 @@ | |
| }, | ||
| "serve": { | ||
| "executor": "@angular-builders/custom-webpack:dev-server", | ||
| "defaultConfiguration": "local", | ||
| "options": { | ||
| "buildTarget": "gauzy:build", | ||
| "proxyConfig": "apps/gauzy/proxy.conf.json", | ||
|
|
@@ -169,8 +170,7 @@ | |
| "liveReload": true, | ||
| "poll": 0 | ||
| } | ||
| }, | ||
| "defaultConfiguration": "local" | ||
| } | ||
| }, | ||
| "extract-i18n": { | ||
| "executor": "@angular-devkit/build-angular:extract-i18n", | ||
|
|
@@ -182,7 +182,6 @@ | |
| "executor": "@nx/jest:jest", | ||
| "options": { | ||
| "jestConfig": "apps/gauzy/jest.config.js", | ||
| "setupFile": "apps/gauzy/src/test-setup.ts", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: Removing the Prompt for AI agents |
||
| "tsConfig": "apps/gauzy/tsconfig.spec.json" | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -679,9 +679,9 @@ | |
| "@angular-devkit/build-ng-packagr": "0.1002.0", | ||
| "@angular-devkit/core": "^21.0.0", | ||
| "@angular-devkit/schematics": "21.0.0", | ||
| "@angular-eslint/eslint-plugin": "21.0.0", | ||
| "@angular-eslint/eslint-plugin-template": "21.0.0", | ||
| "@angular-eslint/template-parser": "21.0.0", | ||
| "@angular-eslint/eslint-plugin": "21.4.0", | ||
| "@angular-eslint/eslint-plugin-template": "21.4.0", | ||
| "@angular-eslint/template-parser": "21.4.0", | ||
| "@angular/cli": "21.0.6", | ||
| "@angular/compiler-cli": "21.0.7", | ||
| "@commitlint/cli": "^19.6.1", | ||
|
|
@@ -700,20 +700,20 @@ | |
| "@nstudio/web": "^20.0.3", | ||
| "@nstudio/web-angular": "^20.0.3", | ||
| "@nstudio/xplat": "^20.0.3", | ||
| "@nx/angular": "^22.5.2", | ||
| "@nx/cypress": "^22.5.2", | ||
| "@nx/devkit": "^22.5.2", | ||
| "@nx/eslint": "^22.5.2", | ||
| "@nx/eslint-plugin": "^22.5.2", | ||
| "@nx/angular": "23.1.1", | ||
| "@nx/cypress": "23.1.1", | ||
| "@nx/devkit": "23.1.1", | ||
| "@nx/eslint": "23.1.1", | ||
| "@nx/eslint-plugin": "23.1.1", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Nx packages were upgraded to 23.1.1 here, but @nx/eslint-plugin-nx remains pinned at the old 16.0.0-beta.1 release and is still referenced from the root ESLint config. Consider migrating the root ESLint config to @nx/eslint-plugin and dropping the stale @nx/eslint-plugin-nx dependency to avoid using an incompatible legacy package alongside Nx 23. Prompt for AI agents |
||
| "@nx/eslint-plugin-nx": "16.0.0-beta.1", | ||
|
Comment on lines
+707
to
708
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
rg --hidden -n \
--glob 'eslint.config.*' \
--glob '.eslintrc*' \
--glob 'nx.json' \
'`@nx/eslint-plugin-nx`|`@nx/eslint-plugin`' .
yarn why `@nx/eslint-plugin-nx`
yarn why `@nx/eslint-plugin`Repository: ever-co/ever-gauzy Length of output: 2199 🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
echo "## package.json relevant deps"
sed -n '680,730p' package.json
echo
echo "## root eslint.config.js"
cat -n eslint.config.js
echo
echo "## package manager lock references"
rg -n '"`@nx/eslint-plugin-nx`"|"`@nx/eslint-plugin`"' package.json yarn.lock || true
echo
echo "## npm metadata for `@nx/eslint-plugin-nx` versions"
npm view `@nx/eslint-plugin-nx` versions --json | sed -n '1,80p'
npm view `@nx/eslint-plugin-nx`@16.0.0-beta.1 --json | sed -n '1,20p'Repository: ever-co/ever-gauzy Length of output: 3584 Remove the legacy Nx ESLint package usage from the root config.
🤖 Prompt for AI Agents |
||
| "@nx/jest": "^22.5.2", | ||
| "@nx/js": "^22.5.2", | ||
| "@nx/nest": "^22.5.2", | ||
| "@nx/node": "^22.5.2", | ||
| "@nx/web": "^22.5.2", | ||
| "@nx/webpack": "^22.5.2", | ||
| "@nx/workspace": "^22.5.2", | ||
| "@nx/playwright": "^22.5.2", | ||
| "@nx/jest": "23.1.1", | ||
| "@nx/js": "23.1.1", | ||
| "@nx/nest": "23.1.1", | ||
| "@nx/node": "23.1.1", | ||
| "@nx/web": "23.1.1", | ||
| "@nx/webpack": "23.1.1", | ||
| "@nx/workspace": "23.1.1", | ||
| "@nx/playwright": "23.1.1", | ||
| "@playwright/test": "^1.61.0", | ||
| "playwright-bdd": "^9.1.0", | ||
| "@schematics/angular": "^21.0.0", | ||
|
|
@@ -746,7 +746,7 @@ | |
| "cross-env": "^10.1.0", | ||
| "cspell": "^6.18.1", | ||
| "css-minimizer-webpack-plugin": "^7.0.4", | ||
| "cypress": "^15.9.0", | ||
| "cypress": "15.18.1", | ||
| "cypress-cucumber-preprocessor": "^4.3.1", | ||
| "cypress-file-upload": "^5.0.8", | ||
| "cz-conventional-changelog": "^3.3.0", | ||
|
|
@@ -755,11 +755,11 @@ | |
| "envalid": "^6.0.2", | ||
| "esbuild": "0.28.1", | ||
| "eslint": "^9.0.0", | ||
| "eslint-plugin-cypress": "2.13.4", | ||
| "eslint-plugin-cypress": "3.6.0", | ||
| "fork-ts-checker-webpack-plugin": "^5.2.0", | ||
| "gulp-tag-version": "^1.3.1", | ||
| "husky": "^6.0.0", | ||
| "jest": "30.0.0", | ||
| "jest": "30.3.0", | ||
| "jest-environment-jsdom": "30.0.0", | ||
| "jest-environment-node": "^29.7.0", | ||
|
Comment on lines
+762
to
764
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
rg --hidden -n -C 2 \
--glob 'package.json' \
--glob '**/project.json' \
--glob 'jest.config.*' \
--glob '**/*.spec.*' \
'jest-environment-node|jest-environment-jsdom|jest-jasmine2|testEnvironment|`@jest-environment`' .
yarn why jest-environment-nodeRepository: ever-co/ever-gauzy Length of output: 22571 🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
echo "Relevant package.json dependency lines:"
python3 - <<'PY'
import json
p=json.load(open('package.json'))
for key in ['jest','jest-environment-jsdom','jest-environment-node','jest-jasmine2','jest-util']:
print(f"{key}: {p.get('devDependencies',{}).get(key)}")
PY
echo
echo "Lockfile references for jest-environment-node:"
fd '^(yarn.lock|package-lock.json|pnpm-lock.yaml)$' -x sh -c 'echo "--- $1"; rg -n "jest-environment-node" "$1" | head -80' sh {}Repository: ever-co/ever-gauzy Length of output: 1087 🏁 Script executed: #!/usr/bin/env bash
set -euo pipefail
echo "Search for explicit package environment configuration:"
rg --hidden -n \
--glob 'package.json' \
--glob 'nx.json' \
--glob 'jest.preset.js' \
--glob 'jest.config.*' \
--glob 'project.json' \
'jest-environment-node|testEnvironment|preset' .Repository: ever-co/ever-gauzy Length of output: 26514 Keep the root Jest environment packages on the same 30.x line.
🤖 Prompt for AI Agents |
||
| "jest-jasmine2": "30.0.0", | ||
|
|
@@ -773,7 +773,7 @@ | |
| "ng-packagr": "^21.0.0", | ||
| "node-gyp": "^10.2.0", | ||
| "npm-run-all": "^4.1.5", | ||
| "nx": "^22.5.2", | ||
| "nx": "23.1.1", | ||
| "pkg": "^5.3.0", | ||
| "png-to-ico": "^2.1.8", | ||
| "postcss": "^8.4.5", | ||
|
|
@@ -789,7 +789,7 @@ | |
| "simple-git": "^3.36.0", | ||
| "stylelint": "^15.10.1", | ||
| "swc-loader": "^0.2.6", | ||
| "ts-jest": "29.4.6", | ||
| "ts-jest": "29.4.9", | ||
| "ts-loader": "^8.0.4", | ||
| "ts-node": "^10.9.2", | ||
| "tsconfig-paths": "^4.2.0", | ||
|
|
@@ -798,12 +798,13 @@ | |
| "tslint-language-service": "^0.9.9", | ||
| "typedoc": "^0.23.24", | ||
| "typescript": "^5.9.3", | ||
| "verdaccio": "^6.0.5", | ||
| "webpack": "5.104.1", | ||
| "verdaccio": "6.8.0", | ||
| "webpack": "5.108.4", | ||
| "webpack-bundle-analyzer": "^4.10.2", | ||
| "webpack-cli": "^6.0.1", | ||
| "webpack-cli": "7.2.1", | ||
| "webpack-merge": "^6.0.1", | ||
| "webpack-node-externals": "^3.0.0" | ||
| "webpack-node-externals": "^3.0.0", | ||
| "webpack-dev-server": "^5.2.1" | ||
| }, | ||
| "overrides": { | ||
| "prebuild": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,5 +65,3 @@ | |
| }, | ||
| "sideEffects": false | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: The new .gitignore entry is missing a trailing newline at end of file. Add one to conform to POSIX text-file convention and avoid the 'No newline at end of file' diff artifact and potential issues with tooling that expects newline-terminated files.
Prompt for AI agents