EEBus: fix test cleanup regression breaking TestShipPairing - #31617
Merged
Conversation
TestControlBoxGridGuardHeartbeat (PR #31568) never shuts down its server.Instance() or controlbox, relying only on the next test in the package to tear down a leftover instance and on async context cancellation for the controlbox. That was harmless while it was the last test in the package, but PR #31568 landed it before TestShipPairing (alphabetical file order: cs_test.go, gridguard_test.go, pairing_test.go), and TestShipPairing then starts while the GridGuard test's server/controlbox may still be shutting down - explaining the "paired device not routed to consumer" CI failures on PR #31570, which correlate exactly with a "merge master" commit that pulled in PR #31568.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestControlBoxGridGuardHeartbeat(#31568) never shuts down itsserver.Instance()or controlbox, relying only on the next test in the package to tear down a leftover instance and on async context cancellation for the controlbox. That was harmless while it was the last test in the package, but it now runs beforeTestShipPairing(alphabetical file order: cs_test.go, gridguard_test.go, pairing_test.go) — soTestShipPairingcan start while the GridGuard test's server/controlbox is still shutting down.This explains the "paired device not routed to consumer" CI failures on #31570: they started right after a "merge master" commit pulled in #31568, and master itself has been consistently green (nothing else runs after
TestControlBoxGridGuardHeartbeatthere).🤖 Generated with Claude Code