Propagate response body read errors - #8
Merged
evanpurkhiser merged 1 commit intoSep 2, 2026
Conversation
`resp.text().unwrap_or_default()` turns a failed body read into an empty
string, which `request` then returns as `Ok(json!({}))`. A connection
dropped mid-body therefore looks like a successful empty response: the
caller sees a page with no items, `sync_append_log` stops, and the CLI
renders stale data without surfacing an error.
The status stays in the message, since an error status with an unreadable
body was the one case the old code still reported.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the connection mid-page during a sync and
things3 todaystill exits 0,printing whatever the last good sync left behind. Nothing says the sync stopped
early. Now it fails with
failed reading body from <url> (HTTP 200).resp.text().unwrap_or_default()turns the read error into an empty string, andrequesthands that back asOk(json!({})).sync_append_logsees a page withno items and calls it the end of history.
Two other spots discard a
Resultlike this, but neither changes what a commandreturns. Happy to warn and carry on instead of failing, if you'd rather.