fix(common): Improve constant SEP from "-" to "__" for namespaced names #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify test cases to include prompt testing
|
I'm going to incorporate this - but want to also take a look at naming overall (especially servers created with --url or --npx). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to solve the issue #297, please refer to the issue for more details.
I also improved the test case in
test_hyphens_in_name.pyto help to observe and test this problem.By the way, the new value
__(two underlines) of constantSEPis not my final decision, but I have not thought of a better value yet. If you have a better idea, please let me know, thanks!