Skip to content

Conversation

@xzrderek
Copy link
Contributor

@xzrderek xzrderek commented Dec 16, 2025

Note

Switch to API-key-only auth with account ID derived via verifyApiKey, removing auth.ini/profile and FIREWORKS_ACCOUNT_ID usage, and updating CLI, docs, examples, and tests accordingly.

  • Auth:
    • Simplify to API-key-only auth: get_fireworks_api_key reads env; get_fireworks_account_id derives via verifyApiKey against FIREWORKS_API_BASE.
    • Remove auth.ini/profile resolution logic and all references to FIREWORKS_ACCOUNT_ID as input.
    • Update messages/errors to reflect derived account id.
  • CLI:
    • Drop --profile support and related env bootstrapping; keep --server to set FIREWORKS_API_BASE.
    • Update RFT creation and upload flows to resolve account id via API key (_ensure_account_id).
  • Docs/Examples:
    • Remove FIREWORKS_ACCOUNT_ID setup and auth.ini guidance across CONTRIBUTING.md, CLI docs, READMEs, and .env.example.
    • Clarify credential source order: only FIREWORKS_API_KEY (optional FIREWORKS_API_BASE).
  • Platform API:
    • Logging/messages updated; validation requires API key/base only.
  • Tests:
    • Rewrite auth tests to drop ini/profile cases; mock verify_api_key_and_get_account_id where needed.
    • Adjust CLI/evaluation/upload tests to no longer set FIREWORKS_ACCOUNT_ID and to stub account-id derivation.

Written by Cursor Bugbot for commit 7387b85. This will update automatically on new commits. Configure here.

@xzrderek xzrderek requested a review from dphuang2 December 16, 2025 21:41
@xzrderek xzrderek merged commit fdccc92 into main Dec 16, 2025
17 checks passed
@xzrderek xzrderek deleted the derekx/take-out-auth-ini branch December 16, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants