Skip to content

fix page fault #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 7 commits into from
Sep 19, 2025
Merged

fix page fault #197

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6c4d151
fix test
xzrderek Sep 19, 2025
107190d
debug
xzrderek Sep 19, 2025
1ba4bcb
test
xzrderek Sep 19, 2025
2830829
sanity check
xzrderek Sep 19, 2025
c27a9b7
test this
xzrderek Sep 19, 2025
18d7659
test just 9780
xzrderek Sep 19, 2025
a9f5f41
delete
xzrderek Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions tests/pytest/test_mcp_session_autocreate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
without requiring a prior initial state fetch, and returns JSON.
"""

import asyncio
import subprocess
import sys
import time
from multiprocessing import Process

import httpx
import pytest
Expand All @@ -13,29 +15,31 @@
from eval_protocol.types import MCPSession


def _run_airline_server():
import os
@pytest.mark.asyncio
async def test_tool_call_returns_json_without_prior_initial_state():
port = "9780"

python_version = os.environ.get("PYTHON_VERSION", "3.10").replace(".", "")
port = str(9780 + int(python_version[-1:]))
os.environ["PORT"] = port
from eval_protocol.mcp_servers.tau2.tau2_mcp import AirlineDomainMcp
# Create server script to run as subprocess instead of multiprocessing
server_script = """
import sys
import os

server = AirlineDomainMcp(seed=None)
server.run(transport="streamable-http")
port = "9780"
os.environ["PORT"] = port

from eval_protocol.mcp_servers.tau2.tau2_mcp import AirlineDomainMcp

@pytest.mark.asyncio
async def test_tool_call_returns_json_without_prior_initial_state():
import os
server = AirlineDomainMcp(seed=None)
server.run(transport="streamable-http")
"""

proc = Process(target=_run_airline_server, daemon=True)
proc.start()
# Start server as subprocess instead of multiprocessing.Process
proc = subprocess.Popen([sys.executable, "-c", server_script])

try:
python_version = os.environ.get("PYTHON_VERSION", "3.10").replace(".", "")
port = str(9780 + int(python_version[-1:]))
# Give server time to start
await asyncio.sleep(3)

try:
base_url = f"http://127.0.0.1:{port}/mcp"
client = httpx.Client(timeout=1.0)
start_time = time.time()
Expand All @@ -51,7 +55,7 @@ async def test_tool_call_returns_json_without_prior_initial_state():
pass
time.sleep(0.2)
else:
pytest.fail("Server did not start on port 9780 in time")
pytest.fail(f"Server did not start on port {port} in time")

assert ready_time is not None, "Server did not return a successful status before exiting loop"
assert ready_time - start_time < 20, f"Server took too long to respond: {ready_time - start_time:.2f}s"
Expand All @@ -71,4 +75,4 @@ async def test_tool_call_returns_json_without_prior_initial_state():
await mgr.close_session(session)
finally:
proc.terminate()
proc.join(timeout=5)
proc.wait(timeout=5)
Loading