fix: correct factory address checksum in MineSaltForPool#3
Open
aki-0517 wants to merge 1 commit intoeuler-xyz:masterfrom
Open
fix: correct factory address checksum in MineSaltForPool#3aki-0517 wants to merge 1 commit intoeuler-xyz:masterfrom
aki-0517 wants to merge 1 commit intoeuler-xyz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Bug Fix: Checksum Formatting in
MineSaltForPool.s.solRoot Cause
While reviewing the code, I noticed that the address
0x55d09f01fBF9D8D891c6608C5a54EA7AD6d528fbon line 18 ofscript/MineSaltForPool.s.solhas an incorrect checksum format. This led to a compilation error during the initial installation via./install.sh.Solution
I’ve replaced the invalid address with the properly checksummed version:
0x55D09F01fBF9D8D891c6608c5a54eA7aD6d528FB🔧 Changes
File:
euler-devland/script/MineSaltForPool.s.solLine 18: Updated factory address checksum:
0x55d09f01fBF9D8D891c6608C5a54EA7AD6d528fb0x55D09F01fBF9D8D891c6608c5a54eA7aD6d528FB🧪 Testing
After this change, running the installation script:
completes successfully without any compilation errors.