Skip to content

Fix replay offset viewer for downscroll #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CreoSm wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix replay offset viewer for downscroll #1413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Etterna/Actor/Gameplay/NoteDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,12 +803,15 @@ NoteDisplay::DrawReplayActors(const TapNote& tn,
const auto offsetBeat =
td->GetBeatFromElapsedTime(offsetSec + curSec);

const auto reverse_percent = m_pPlayerState->m_PlayerOptions.GetCurrent().GetReversePercentForColumn(column_args.column);
const auto reverse_ydiff_mult = (1 - 2 * reverse_percent);

const auto fYOffset = ArrowEffects::GetYOffset(
m_pPlayerState, column_args.column, offsetBeat);
const auto perfectYOffset =
ArrowEffects::GetYOffset(m_pPlayerState,
column_args.column, NoteRowToBeat(row));
const auto ydiff = perfectYOffset - fYOffset;
const auto ydiff = (perfectYOffset - fYOffset) * reverse_ydiff_mult;

if (ydiff < 0) {
replay_offset_body->SetVertAlign(1);
Expand Down
Loading