Skip to content

Conversation

BeardOverflow
Copy link

@BeardOverflow BeardOverflow commented Aug 24, 2025

Identify the Bug

#346

Description of the Change

Corrected the logic used to determine whether TCP_FASTOPEN should be enabled based on the Linux kernel version.

The original version incorrectly evaluated some kernel versions and it only allowed TCP_FASTOPEN on version Kernel 3.7+, but failed to correctly handle minor version lower than 7 for major versions greater than 3.

For example, kernel versions 6.1 and 6.6 were incorrectly excluded, even though they support TCP_FASTOPEN because its minor version is lower than 7.

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

I have used github search engine and git blame.

The first commit introducing this kernel value check was authored 10 years ago: a730551
The first commit suggests Kernel 3.6 to support TCP_FASTOPEN, but a newer commit change it to 3.7: 8786b2f

No more related commits.

Release Notes

  • Fixed kernel version check for TCP_FASTOPEN support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant