feat(spec-specs, spec-tests): add EIP-7976#2861
Open
felix314159 wants to merge 6 commits into
Open
Conversation
* feat(tests): adds tests and src changes for 7976 Co-authored-by: Toni Wahrstätter <51536394+nerolation@users.noreply.github.com> * feat: EIP got updated * fix: ruff * feat: implemented PR feedback * fix: make eip-7934 block-size filler fork-aware for amsterdam by enforcing tx gas caps and adaptive calldata sizing so --until=amsterdam fills pass * fix: fix * fix: fix * fix: mypy --------- Co-authored-by: Toni Wahrstätter <51536394+nerolation@users.noreply.github.com>
Align the EIP-7976 mixin and tests with the GasCosts dataclass rename on forks/amsterdam (GAS_TX_BASE -> TX_BASE, GAS_TX_DATA_TOKEN_FLOOR -> TX_DATA_TOKEN_FLOOR, GAS_VERY_LOW -> VERY_LOW, etc.).
Override `calldata_gas_calculator` (floor mode only) instead of `transaction_data_floor_cost_calculator`. The previous override shadowed EIP-7981's `transaction_data_floor_cost_calculator` in the Amsterdam MRO (auto-loader sorts by EIP number ascending, so EIP7976 is more derived and its method wins without calling super), dropping the access list floor contribution. Routing the change through `calldata_gas_calculator` lets EIP-7623's data floor calculator pick it up, which EIP-7981 then extends via super.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2861 +/- ##
================================================
Coverage 87.14% 87.14%
================================================
Files 586 586
Lines 35792 35792
Branches 3364 3364
================================================
Hits 31192 31192
Misses 3950 3950
Partials 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
i'm looking into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Merge EIP-7976 into
forks/amsterdam.🔗 Related Issues or PRs
forks/amsterdam#2846✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture