feat(tests): eip7928 checklist v1#2859
Merged
fselmo merged 3 commits intoMay 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2859 +/- ##
===================================================
+ Coverage 86.94% 87.14% +0.20%
===================================================
Files 586 586
Lines 35777 35792 +15
Branches 3363 3364 +1
===================================================
+ Hits 31106 31192 +86
+ Misses 4012 3950 -62
+ Partials 659 650 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
reviewed
May 15, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
Looks great overall. I've flagged two issues with the fork transition tests. It might be an issue with our framework.
…ename as future issue
marioevz
approved these changes
May 15, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the changes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
These are the last remaining tests that I believe get us to a really good spot for the testing checklist for EIP-7928 (BALs).
As mentioned in the testing calls, I think there are some very real missing gaps that the current version of the checklist doesn't cover for complex EIPs that now have different behavior at different opcode gas boundaries, etc. As we discussed, this will likely be on some V2 of the checklist and I'm already working on a version of this with EIP-7928 and some of EIP-8037 as good candidates for what surface areas to expand upon.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Cute Animal Picture