Skip to content

feat(tests): eip7928 checklist v1#2859

Merged
fselmo merged 3 commits into
ethereum:forks/amsterdamfrom
fselmo:feat/eip7928-checklist-v1
May 15, 2026
Merged

feat(tests): eip7928 checklist v1#2859
fselmo merged 3 commits into
ethereum:forks/amsterdamfrom
fselmo:feat/eip7928-checklist-v1

Conversation

@fselmo
Copy link
Copy Markdown
Contributor

@fselmo fselmo commented May 14, 2026

🗒️ Description

These are the last remaining tests that I believe get us to a really good spot for the testing checklist for EIP-7928 (BALs).

As mentioned in the testing calls, I think there are some very real missing gaps that the current version of the checklist doesn't cover for complex EIPs that now have different behavior at different opcode gas boundaries, etc. As we discussed, this will likely be on some V2 of the checklist and I'm already working on a version of this with EIP-7928 and some of EIP-8037 as good candidates for what surface areas to expand upon.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Cute Animal Picture

Screenshot 2026-05-14 at 15 54 38

@fselmo fselmo requested a review from marioevz May 14, 2026 21:55
@fselmo fselmo added C-feat Category: an improvement or new feature A-tests Area: Consensus tests. labels May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.14%. Comparing base (b3f5df5) to head (592bd58).
⚠️ Report is 4 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2859      +/-   ##
===================================================
+ Coverage            86.94%   87.14%   +0.20%     
===================================================
  Files                  586      586              
  Lines                35777    35792      +15     
  Branches              3363     3364       +1     
===================================================
+ Hits                 31106    31192      +86     
+ Misses                4012     3950      -62     
+ Partials               659      650       -9     
Flag Coverage Δ
unittests 87.14% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. I've flagged two issues with the fork transition tests. It might be an issue with our framework.

Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes 👍

@fselmo fselmo merged commit 892e6d1 into ethereum:forks/amsterdam May 15, 2026
24 checks passed
@fselmo fselmo deleted the feat/eip7928-checklist-v1 branch May 15, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants