feat(spec-specs, spec-tests): add EIP-7843 SLOTNUM opcode#2853
Merged
marioevz merged 8 commits intoMay 14, 2026
Conversation
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following ethereum#2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
Replace stale GAS_BASE reference with GasCosts.OPCODE_SLOTNUM (= BASE) to match the opcode gas naming convention used across block instructions on forks/amsterdam. Also update the test-fork mixin to use gas_costs.BASE instead of the retired gas_costs.GAS_BASE.
kclowes
changed the title
kclowes
added
A-spec-specs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2853 +/- ##
===================================================
- Coverage 86.94% 86.94% -0.01%
===================================================
Files 586 586
Lines 35767 35777 +10
Branches 3362 3363 +1
===================================================
+ Hits 31098 31106 +8
- Misses 4010 4012 +2
Partials 659 659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
reviewed
May 13, 2026
8 tasks
spencer-tb
previously requested changes
May 14, 2026
Contributor
There was a problem hiding this comment.
Some extra cases, feel free to add to this PR or the testing tracker.
- Multi block case, where we have two blocks ("within the same slot") where block 1 and 2 do not have the same slot number.
- Fork transition test. Check not enabled before fork and enabled after fork.
We should add a mainnet test for execute here too I think!
Contributor
Author
|
@spencer-tb I don't want to block this process, so added an issue here: #2856 ! Will pick up shortly. |
marioevz
dismissed
spencer-tb’s stale review
Comments were addressed and new requested tests are tracked in a new issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Merge EIP-7843 into forks/amsterdam.
🔗 Related Issues or PRs
forks/amsterdam#2846✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Cute Animal Picture