test(tests): inter-dependent tx tests for BAL parallelization#2851
Merged
marioevz merged 3 commits intoMay 14, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2851 +/- ##
===================================================
- Coverage 90.01% 86.94% -3.07%
===================================================
Files 539 586 +47
Lines 32618 35767 +3149
Branches 3030 3362 +332
===================================================
+ Hits 29361 31098 +1737
- Misses 2699 4010 +1311
- Partials 558 659 +101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
reviewed
May 13, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
Looks good, I suggested some extra variations of the tests included. Let me know if the description of these tests are clear. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
From ETH R&D @matkt:
https://discord.com/channels/595666850260713488/1364000387195076608/1504026078107275274
Add five new cross-tx parallelization-correctness tests:
test_bal_cross_tx_storage_chain— 8-tx fibonacci chain on one contract... each tx i ≥ 2 writesslot[i] = SLOAD(i-1) + SLOAD(i-2)-- transactions are dependent on previous 2. Catches clients that fail to apply prior txs BAL storage changes.test_bal_cross_tx_deploy_then_call(@with_all_create_opcodes) — tx1CREATE/CREATE2s a contract; tx2CALLs it. Catches clients that hit an empty account because tx1'scode_changesweren't applied.test_bal_cross_tx_balance_dependency— tx1 sends value to a contract; tx2 calls the contract andSSTOREsSELFBALANCE. Catches clients that read the pre-block balance.test_bal_7702_cross_tx_delegation_then_call— tx1 installs an EIP-7702 delegation onalice; tx2 and tx3 callaliceto increment slot0, using different senders. Catches clients that don't apply the delegation or skip the intermediate increment.test_bal_cross_tx_funding_chain— Five-tx chainalice→bob→charlie→dan→eunice→targetwhere each intermediate starts empty and only becomes solvent once the prior tx's BALbalance_changesare applied;oog_minus_1additionally exercises target'sstorage_readswhen eunice'sSSTOREOOGs one gas short.✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture