feat(tests): Add contract creation tests for 7951 #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
added
scope:tests
Comment on lines
314
to
326
| + Op.SSTORE( | ||
| 0, | ||
| Op.CALL( | ||
| gas=Spec.P256VERIFY_GAS, | ||
| address=Spec.P256VERIFY, | ||
| value=0, | ||
| args_offset=0, | ||
| args_size=len(input_data), | ||
| ret_offset=0, | ||
| ret_size=len(input_data) + 32, | ||
| ), | ||
| ) | ||
| + Op.SSTORE(1, Op.MLOAD(0)) |
There was a problem hiding this comment.
What about using the Storage object? This could simplify the slot management!
The storage updated logic can be updated as follow, and we do not need to assign slots.
storage = Storage()
storage.store_next(true, Op.CALL(...))
storage.store_next(len(expected_output), Op.RETURNDATASIZE)
storage.store_next(expected_output, Op.MLOAD(0))For the post storage, it could be updated as:
post = {
contract_address: {
"storage":storage,
},
}This can be applied to the test case below also!
| ), | ||
| ) | ||
| + Op.SSTORE(1, Op.MLOAD(0)) | ||
| + Op.RETURN(0, 32) |
There was a problem hiding this comment.
Maybe here we only need 32 bytes as the return data size according to eip-7951?
Some small suggestion (nit) here, we can use STOP instead of RETURN maybe, but it works fine for both.
Op.CALL(
gas=Spec.P256VERIFY_GAS,
address=Spec.P256VERIFY,
value=0,
args_offset=0,
args_size=len(input_data),
ret_offset=0,
ret_size=len(input_data) + 32, # return data is 32 bytes
),There was a problem hiding this comment.
Nice catches, thanks!
|
Thanks for the PR, leave some comment above. Please let me know if there is anything unclear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add a few more tests for the p256verify precompile, specifically around what happens if a contract calls a precompile on initialization.
🔗 Related Issues or PRs
#1794
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.