Skip to content

Conversation

LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Aug 13, 2025

πŸ—’οΈ Description

Enhance test coverage for eip-7825 checklist, all the testing scenario can be found in issue #1793.

πŸ”— Related Issues or PRs

Issue #1793

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Aug 13, 2025
@LouisTsai-Csie LouisTsai-Csie added fork:osaka Osaka hardfork type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Aug 13, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing additions, I added comments that could be simply committed as-is and should not break anything.

However I didn't add comments to test_tx_gas_limit_cap_contract_creation, test_tx_gas_limit_cap_access_list_with_diff_keys, test_tx_gas_limit_cap_access_list_with_diff_addr, nor test_tx_gas_limit_cap_authorized_tx, but the same comments to test_tx_gas_limit_cap_full_calldata apply to these tests too!

@LouisTsai-Csie LouisTsai-Csie force-pushed the enhance-eip7825-coverage branch from 5b222b0 to 7ec7c1a Compare August 22, 2025 12:41
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing additions, thanks so much for implementing these, let's get them in the next release.

@marioevz marioevz merged commit 3642b20 into ethereum:main Aug 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants