-
Notifications
You must be signed in to change notification settings - Fork 170
feat(tests): enhance eip7825 test coverage for checklist #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): enhance eip7825 test coverage for checklist #2034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing additions, I added comments that could be simply committed as-is and should not break anything.
However I didn't add comments to test_tx_gas_limit_cap_contract_creation
, test_tx_gas_limit_cap_access_list_with_diff_keys
, test_tx_gas_limit_cap_access_list_with_diff_addr
, nor test_tx_gas_limit_cap_authorized_tx
, but the same comments to test_tx_gas_limit_cap_full_calldata
apply to these tests too!
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit_transition_fork.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7825_transaction_gas_limit_cap/test_tx_gas_limit.py
Outdated
Show resolved
Hide resolved
5b222b0
to
7ec7c1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing additions, thanks so much for implementing these, let's get them in the next release.
ποΈ Description
Enhance test coverage for eip-7825 checklist, all the testing scenario can be found in issue #1793.
π Related Issues or PRs
Issue #1793
β Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_from
marker.