feat(tests): execute blob tests client agnostic #1720
+50
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
scope:tests
spencer-tb
force-pushed
the
hive-execute-blobs-geth-fix
branch
from
a9a328d to
725a77b
Compare
spencer-tb
force-pushed
the
hive-execute-blobs-geth-fix
branch
from
e134511 to
12a87c3
Compare
danceratopz
reviewed
Jun 8, 2025
| This runs at test execution time when we have access to both the fork and client type. | ||
| """ | ||
| requested_id = request.param | ||
| all_test_cases = generate_full_blob_tests(fork, client_type) |
There was a problem hiding this comment.
I think this will unnecessarily generate the blobs for all tests in the setup of every test case. Applying scope="module" to the fixture will avoid this.
danceratopz
reviewed
Jun 8, 2025
| @pytest.mark.parametrize_by_fork( | ||
| "txs_blobs", | ||
| generate_full_blob_tests, | ||
| @pytest.fixture |
There was a problem hiding this comment.
Suggested change
| @pytest.fixture | |
| @pytest.fixture(scope="module") |
| """Get max blobs per tx considering both fork and client.""" | ||
| # https://github.com/ethereum/go-ethereum/issues/31792 | ||
| # https://github.com/ethereum/go-ethereum/pull/31837 | ||
| if client_type and "go-ethereum" in client_type.name and fork >= Osaka: |
There was a problem hiding this comment.
Hmm, could it ever be geth? In the client YAML, yes. But I'm not sure where the client type comes from, perhaps it's fixed by Hive and doesn't come from the YAML (e.g., client field or nametag field)? I can check later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Updates the peerdas blob tests for execute hive mode to be client agnostic with respect to max blobs per tx. Additionally adds some cleanup to
tests/osaka/eip7594_peerdas/test_get_blobs.py.Geth now passes the
test_get_blobs[...single_blob_max_txs]test!🔗 Related Issues
ethereum/go-ethereum#31837
✅ Checklist