-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Semrush SEO errors #16100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semrush SEO errors #16100
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
{ | ||
protocol: "https", | ||
hostname: "github.com", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... curious where this is needed? Small note, but keeping in mind any domain patterns we allow here would allow others to use our next server to optimize their images...
ie, anyone could use our servers to optimize any github-hosted image, using this pattern: https://ethereum.org/_next/image/?url=<any-github-hosted-image-url>&w=<size>&q=<quality>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking now, but we may want to consider a way to pull the bug-bounty images that this is intended for to use the avatars.githubusercontent.com domain instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment applies to all non-English files, but we either
- must get these updates in Crowdin immediately upon merging to avoid the onslaught of regressions on the 1st of the month (cc: @lukassim), or
- remove them to let the Crowdin flow address these corrections
cc: @lukassim |
{ | ||
protocol: "https", | ||
hostname: "github.com", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking now, but we may want to consider a way to pull the bug-bounty images that this is intended for to use the avatars.githubusercontent.com domain instead.
seo - internal images are broken (category in semrush)
seo - internal links are broken (category in semrush)
seo - duplicate meta description (category in semrush)
seo - returned 4XX status code (category in semrush)
seo - incorrect hreflang links (category in semrush)
seo - hreflang conflicts wihtin page source code (category in semrush)
seo - incorrect pages found in sitemap.xml (category in semrush)
seo - duplicate title tags (category in semrush)
seo - duplicate content issues (category in semrush)