feat: cache result of ABIType.to_type_str #244
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
commented
May 17, 2025
| type_str = self._type_str = self.base + sub + arrlist | ||
| return type_str | ||
|
|
||
| @property |
Author
There was a problem hiding this comment.
is there a reason we don't use cached_property here?
Author
There was a problem hiding this comment.
It won't let me comment in the correct place, so I'll ask here.
secondly, is there a reason we don't use cached_property on is_dynamic (or set it during init)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ABIType.to_type_str can be called multiple times on an instance, so its result should be cached for better performance
Related to Issue #
Closes #
How was it fixed?
Todo:
Cute Animal Picture