Skip to content

Conversation

@sigma
Copy link
Contributor

@sigma sigma commented Feb 25, 2025

Description

This change adds:

  • capabilities in op-deployer to leverage op-program-svc to generate prestates on demand based on genesis/rollup information calculated during the deployment.
  • enablement code to allow the kurtosis package to make use of these capabilities

See ethpandaops/optimism-package#210 for the kurtosis-side.

Tests

Additional context

Metadata

@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 14.37500% with 137 lines in your changes missing coverage. Please review.

Project coverage is 42.28%. Comparing base (bc888ba) to head (a4d6b41).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/pipeline/env.go 0.00% 44 Missing ⚠️
op-deployer/pkg/deployer/pipeline/pre_state.go 0.00% 42 Missing ⚠️
...p-deployer/pkg/deployer/pipeline/interop_depset.go 0.00% 19 Missing ⚠️
op-deployer/pkg/deployer/apply.go 26.31% 13 Missing and 1 partial ⚠️
devnet-sdk/proofs/prestate/client.go 0.00% 9 Missing ⚠️
op-service/testutils/devnet/prestatebuilder.go 72.00% 6 Missing and 1 partial ⚠️
op-deployer/pkg/deployer/inspect/genesis.go 0.00% 1 Missing ⚠️
op-deployer/pkg/deployer/inspect/rollup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14524      +/-   ##
===========================================
- Coverage    46.47%   42.28%   -4.20%     
===========================================
  Files         1183     1014     -169     
  Lines       101199    91093   -10106     
===========================================
- Hits         47036    38519    -8517     
+ Misses       50818    49411    -1407     
+ Partials      3345     3163     -182     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/flags.go 28.57% <ø> (ø)
op-deployer/pkg/deployer/state/state.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/inspect/genesis.go 0.00% <0.00%> (-33.34%) ⬇️
op-deployer/pkg/deployer/inspect/rollup.go 0.00% <0.00%> (ø)
op-service/testutils/devnet/prestatebuilder.go 72.00% <72.00%> (ø)
devnet-sdk/proofs/prestate/client.go 0.68% <0.00%> (+0.68%) ⬆️
op-deployer/pkg/deployer/apply.go 46.42% <26.31%> (-1.47%) ⬇️
...p-deployer/pkg/deployer/pipeline/interop_depset.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/pipeline/pre_state.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/pipeline/env.go 0.00% <0.00%> (ø)

... and 181 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigma sigma force-pushed the sigma/op-program-svc branch 2 times, most recently from 49bdec0 to ca0b9eb Compare March 4, 2025 20:18
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Mar 22, 2025
@opgitgovernance
Copy link
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@sigma sigma force-pushed the sigma/op-program-svc branch from 1b76b2a to c04ba87 Compare March 26, 2025 20:21
@sigma sigma removed the S-stale Status: Will be closed unless there is activity label Mar 26, 2025
@sigma sigma force-pushed the sigma/op-program-svc branch 3 times, most recently from 1dd00ca to 03281a5 Compare March 27, 2025 15:08
@sigma sigma changed the title sigma/op program svc feat(kurtosis-devnet): enable op-deployer to generate prestate through op-program-svc Mar 27, 2025
@sigma sigma marked this pull request as ready for review March 27, 2025 15:42
@sigma sigma requested review from a team as code owners March 27, 2025 15:42
* feat(op-deployer): pre-state generation

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* chore: shift genesisAndRollup generation to a share-able place

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* chore: mock-based testing of pre state generation

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* fix: test to just hex decode the generated prestates

Signed-off-by: Yashvardhan Kukreja <[email protected]>

* chore: cleanups

Signed-off-by: Yashvardhan Kukreja <[email protected]>

---------

Signed-off-by: Yashvardhan Kukreja <[email protected]>
@sigma sigma force-pushed the sigma/op-program-svc branch from 03281a5 to 2a5838a Compare March 28, 2025 09:06
Also cleanup the op-program-svc builders
@sigma sigma force-pushed the sigma/op-program-svc branch from 2a5838a to a4d6b41 Compare March 28, 2025 20:42
@sigma sigma enabled auto-merge March 28, 2025 20:44
@sigma sigma added this pull request to the merge queue Mar 28, 2025
Merged via the queue into develop with commit c24fcf4 Mar 28, 2025
50 checks passed
@sigma sigma deleted the sigma/op-program-svc branch March 28, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants