fix: resolve duplicate shortName for ONFA Chain and add icon to Mainnet#8233
fix: resolve duplicate shortName for ONFA Chain and add icon to Mainnet#8233mrchipdev wants to merge 26 commits intoethereum-lists:masterfrom
Conversation
Fix unique chain name
…vvahfbpuq6jz4tqzu
Fix prettier formatting
Fix prettier formatting
Update name: ONFA Chain Testnet
Update shortName: onfachain-testnet
Add RPC and Update Icon
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
|
also:
just checked this - it is not the case and I would be really surprised as the CI would not allow to merge this |
Edit short name
Summary
This PR fixes issues with the ONFA Chain entries:
1. Fix duplicate
shortName(breaking validation)eip155-12082025.json(Mainnet) andeip155-8691942025.json(Testnet) both used"shortName": "onfachain", which violates the uniqueshortNamerequirement.shortNamefrom"onfachain"to"onfachain-testnet"to resolve the conflict.2. Add missing
iconfield to Mainnet"icon": "onfachain"toeip155-12082025.jsonto reference the existing icon definition in_data/icons/onfachain.json.Files Changed
_data/chains/eip155-8691942025.json— updatedshortNameto"onfachain-testnet"_data/chains/eip155-12082025.json— added"icon": "onfachain"