Fix installation of local plugins (fixes #6912)#6913
Merged
SamTV12345 merged 1 commit intoether:developfrom Apr 5, 2025
Merged
Fix installation of local plugins (fixes #6912)#6913SamTV12345 merged 1 commit intoether:developfrom
SamTV12345 merged 1 commit intoether:developfrom
Conversation
Member
|
Thanks for the fix. I'll merge when the pipeline is happy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background for this pull request is contained in #6912.
This pull request does 3 things:
local_pluginsin the root repository, with a.gitignorefile that ignores all of its contents.bin/installLocalPlugins.sh.Dockerfileto change the installation process of local plugins:local_pluginsdirectory into the container (if the directory does not exist, it skips it).ETHERPAD_LOCAL_PLUGINS_ENVbin/installLocalPlugins.sh(which usespnpm install -w "local_plugins/${plugin}/")(note: I am not sure that the
pnpm -w installcommand is the best way to install a plugin, I am not an expert node user.)To install a plugin locally put the it inside the
local_pluginsdirectory and pass the name of the directoryETHERPAD_LOCAL_PLUGINS, like this (full log: build-pr-1.log):(I am using the
ep_disable_reset_authorship_coloursas an example)When running the container with the following command:
The log shows the following line:
(full log: run-pr-1.log)