fix: group Font Color with other font-formatting menu entries (#35)#139
Merged
JohnMcLear merged 1 commit intomainfrom Apr 17, 2026
Merged
fix: group Font Color with other font-formatting menu entries (#35)#139JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
The file-menu entry opened with a leading \`<hr>\`, so when Etherpad composes all the plugin-provided file-menu blocks the Font Color entry ended up in its own standalone group after a separator, instead of sitting alongside Font Size / Font Family like every other font-format option. Dropping the \`<hr>\` lets it render inside the existing formatting group. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35. The Font Color file-menu entry had a leading
<hr>, so it rendered as its own standalone group after a separator — away from Font Size / Font Family where it logically belongs. Drop the<hr>and the entries collapse into the same formatting group.