Fix slice offset semantics in pointers-react mockState#178
Merged
Conversation
The createMockState adapter used a right-aligned big-endian calculation (32 - offset - length) for stack, storage, and transient slice offsets. The correct convention is direct byte offset from the start of the word, matching the ganache test adapter and evm machine adapter.
Contributor
|
Member
Author
|
Reviewed — this looks correct. The fix changes from right-aligned big-endian calculation ( Verified this matches the convention in all other Machine.State adapters:
All three locations in mockState.ts (stack peek, storage read, transient read) are consistently fixed. No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
createMockStateadapter inpackages/pointers-react/src/utils/mockState.tsused a right-aligned big-endian calculation (32 - offset - length) for stack, storage, and transient slice offsets. This is incorrect — the Machine.State interface treatsslice.offsetas a direct byte offset from the start of the 32-byte word.Changed all three locations (stack peek, storage read, transient read) to use
data.slice(offset, offset + length), matching the convention used by:packages/pointers/test/ganache.ts(reference adapter)packages/evm/src/machine.ts(EVM adapter)packages/programs-react/src/utils/traceState.ts(fixed in PR Wire TraceProvider variable resolution to @ethdebug/pointers #175)