Conversation
…, yarn build - Align bugc vitest/coverage/ui versions from ^2.1.8 to ^3.2.4 to match all other packages and root; update deprecated `threads: false` to `pool: "forks"` for vitest 3 compatibility - Add missing tsconfig paths for #evmgen/program-builder and #irgen/debug/variables in bugc (were in package.json imports but missing from tsconfig, breaking IDE resolution) - Fix `yarn build` to generate schema yamls.ts before tsc, so it works on fresh clones without a prior `yarn install` - Update GitHub Actions from v3 to v4 across all CI workflows (checkout and setup-node)
|
gnidan
left a comment
gnidan
left a comment
There was a problem hiding this comment.
Reviewed all 4 changes — looks good:
-
Vitest alignment: bugc was the only package on
^2.1.8while everything else uses^3.2.4. Thethreads: false→pool: "forks"migration is the correct vitest 3 equivalent. yarn.lock cleanup properly removes all vitest 2 transitive deps. -
tsconfig paths: Both
#evmgen/program-builderand#irgen/debug/variablesare used in source and have corresponding source files. Cross-checked all 37 non-wildcard import keys against tsconfig paths — no other gaps remain. -
Build fix:
yarn --cwd packages/format prepare:yamlsbeforetsc --buildensuresyamls.tsexists on fresh clones. This was the exact issue I hit setting up my worktree. -
CI actions v3→v4: Straightforward, all 3 workflow files updated consistently.
CI green (all 4 checks). LGTM.
1 participant
Summary
Fixes four build system issues:
Align bugc vitest versions: bugc had vitest/coverage/ui pinned at
^2.1.8while all other packages and root use^3.2.4, causing a duplicate local installation. Updated to^3.2.4and replaced deprecatedthreads: falsewithpool: "forks"for vitest 3 compatibility.Add missing bugc tsconfig paths:
#evmgen/program-builderand#irgen/debug/variableswere defined in package.json imports (and used in source) but missing from tsconfig.json paths, breaking IDE resolution for those imports.Fix
yarn buildon fresh clones: Rootyarn buildrantsc --builddirectly without first generating the auto-generatedyamls.tsfile that@ethdebug/formatdepends on. Now runsprepare:yamlsbeforetsc --build.Update CI actions to v4: All three GitHub Actions workflows used
actions/checkout@v3andactions/setup-node@v3(which use deprecated Node 16 runtime). Updated to v4.