Add --action verify to decouple proof verification measurements#260
Merged
Add --action verify to decouple proof verification measurements#260
--action verify to decouple proof verification measurements#260Conversation
jsign
commented
Feb 12, 2026
Comment on lines
+43
to
+54
| // Warmup pass: verify the first proof to warm up the zkVM setup (if any). | ||
| if let Some(first) = proof_entries.first() { | ||
| info!( | ||
| "Warmup: verifying {} (result will be discarded)", | ||
| first.path().display() | ||
| ); | ||
| let proof_bytes = fs::read(first.path()) | ||
| .with_context(|| format!("Failed to read proof from {}", first.path().display()))?; | ||
| let proof = ere_zkvm_interface::Proof::new(ProofKind::Compressed, proof_bytes); | ||
| let _ = panic::catch_unwind(panic::AssertUnwindSafe(|| zkvm.verify(&proof))); | ||
| info!("Warmup complete"); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I remember the suggestion of using some zisk env whenever we use the cluster mode (i.e. rom setup and similars), but I feel this is a more general approach that can be better to have similar considerations for all zkvms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add s adecoupled proof verification with a new action
--action verify--action verifyto verify pre-generated proofs from a local folder or remote .tar.gz URL, enabling a decoupled prove/verify workflow across different machines--save-proofs <folder>flag to persist proof artifacts during--action proveruns--action verifyis used, support--proofs-folderor--proofs-urlflags to load proofs for verification from local disk or a remote archiveVerificationMetricsto the metrics crate for standalone verification reportingThis enables a two-step workflow:
--action prove--save-proofs my-proofsgenerates and saves proof files organized by execution-client/zkvm version--action verify--proofs-folder my-proofs(or--proofs-url https://...tar.gz) loads and verifies the proofs, recording verification time and proof size.If you want to give a shot to 50 mainnet proofs I created with the 8x5090, you can do:
since I uploaded the generated proofs in some repo -- mostly to make it easy to measure verification time in a EIP-7870 machine without having to move the proofs there or similar.
I'll create a dashboard with measurements as we did for proving times, so we have a single place to track these numbers.