Merged
Conversation
jsign
commented
Feb 10, 2026
| const DEFAULT_GUEST_VERSION: &str = "v0.5.0"; | ||
|
|
||
| /// A zkVM instance bundled with ELF bytes (used for profiling). | ||
| pub struct ZkVMInstance { |
Collaborator
Author
There was a problem hiding this comment.
Before we moved just DockerizedzkVM between the setup and run phase. Now we move ZkVMInstance which also contains the ELF needed if the new flag is activated.
Comment on lines
-95
to
+96
| .iter() | ||
| .par_iter() |
Collaborator
Author
There was a problem hiding this comment.
Unrelated improvement: parallelize input generation from fixtures. Helps to save some seconds if we have many fixtures to run.
| } | ||
|
|
||
| /// Runs Zisk profiling for a single fixture. | ||
| pub fn run_profiling( |
Collaborator
Author
There was a problem hiding this comment.
TL;DR: ziskemu -X -S -D -e with the ELF and raw inputs, saving the output to the desired folder.
| cli.action | ||
| ); | ||
| } | ||
| if cli.zkvms.len() != 1 || cli.zkvms[0] != zkVMKind::Zisk { |
Collaborator
Author
There was a problem hiding this comment.
Be a bit strict here to avoid confusions.
jsign
commented
Feb 10, 2026
Collaborator
Author
There was a problem hiding this comment.
Not super interesting to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to dump Zisk profiles when running in
executemode.If the
--zisk-profileflag is added when using--action execute, it will dumpziskemuprofiles of all executed fixtures in an output folder (zisk-profilesby default or can be overridden by--zisk-profile-output).I also added a Python script that can read this output folder and provide some summary about all the fixture runs regarding costs (e.g. avg, min, max, etc.), and also a plot to have an easier visual on this. I'll soon share a HackMD doc with results from 500 mainnet blocks.