Skip to content

Fix local lint setup#84

Merged
devanoneth merged 1 commit into
eternalsafefrom
fix-local-lint-setup
Apr 23, 2026
Merged

Fix local lint setup#84
devanoneth merged 1 commit into
eternalsafefrom
fix-local-lint-setup

Conversation

@devanoneth
Copy link
Copy Markdown
Contributor

Summary

  • Align stale test fixtures and mocks with current SDK, gateway, transaction history, and token types so the test suite typechecks cleanly.
  • Remove a duplicate useEffect dependency from ReviewSignMessageOnChain.

Why

yarn lint runs tsc && next lint. The TypeScript pass was failing on outdated test-only fixtures, and Next lint reported a duplicate hook dependency. These issues blocked clean local setup and verification even though the runtime Jest tests were passing.

Validation

  • yarn install --frozen-lockfile --check-files
  • yarn lint
  • yarn test --watchAll=false
  • yarn build

Notes: the IPFS token-list test needs network access for dweb.link, and the Next build needed unsandboxed local IPC permission in this environment.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wallet Ready Ready Preview, Comment Apr 23, 2026 3:44pm

@github-actions
Copy link
Copy Markdown

📦 Next.js Bundle Analysis for eternalsafe-wallet

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.14 MB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions
Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.33% (-0.01% 🔻)
7625/10122
🔴 Branches
53.88% (+0.03% 🔼)
1869/3469
🔴 Functions 57.92% 1111/1918
🟡 Lines
77.24% (-0.01% 🔻)
6860/8881
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / txHistorySlice.ts
91.18% (-2.94% 🔻)
81.82% 80%
93.1% (-3.45% 🔻)

Test suite run success

902 tests passing in 161 suites.

Report generated by 🧪jest coverage report action from c3880a2

@devanoneth devanoneth marked this pull request as ready for review April 23, 2026 15:50
@devanoneth devanoneth merged commit 8605adb into eternalsafe Apr 23, 2026
6 checks passed
@devanoneth devanoneth deleted the fix-local-lint-setup branch April 23, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant