Skip to content

raft: reduce async storage missing entry log noise#452

Open
NasitSony wants to merge 1 commit into
etcd-io:mainfrom
NasitSony:reduce-async-storage-log-noise
Open

raft: reduce async storage missing entry log noise#452
NasitSony wants to merge 1 commit into
etcd-io:mainfrom
NasitSony:reduce-async-storage-log-noise

Conversation

@NasitSony

Copy link
Copy Markdown

Summary

Downgrade the log message

entry at index %d missing from unstable log; ignoring

from info level to debug level.

Motivation

With async storage writes enabled, this condition can occur during normal processing and generates noisy info-level logs. Since the condition is expected and non-actionable in this mode, debug level is more appropriate.

Testing

  • Updated async storage trace expectations.
  • Ran go test ./....
  • All tests passed.

Fixes #307.

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NasitSony
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

Copy link
Copy Markdown

Hi @NasitSony. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async storage has really noisy logs

2 participants