Skip to content

refactor: replace interface{} with any (Go 1.18+)#451

Merged
ahrtr merged 1 commit into
etcd-io:mainfrom
MD-Mushfiqur123:refactor/interface-to-any
Jun 15, 2026
Merged

refactor: replace interface{} with any (Go 1.18+)#451
ahrtr merged 1 commit into
etcd-io:mainfrom
MD-Mushfiqur123:refactor/interface-to-any

Conversation

@MD-Mushfiqur123

Copy link
Copy Markdown
Contributor

Replace interface{} with any (available since Go 1.18) across 5 files:

  • logger.go
  • state_trace_nop.go
  • raft_test.go
  • node_util_test.go
  • rafttest/interaction_env_logger.go

This project already requires Go 1.26 (see go.mod).

@k8s-ci-robot

Copy link
Copy Markdown

Hi @MD-Mushfiqur123. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logica0419

logica0419 commented Jun 15, 2026

Copy link
Copy Markdown

@MD-Mushfiqur123
Hi, thanks for the PR!

However, the DCO check is currently failing. This means the commit message does not include a Signed-off-by: line.
This line is important for long-term project maintenance. I'd appreciate your understanding.

Please follow the instructions provided in the DCO check log and update the commit accordingly.
I also recommend configuring Git to add a signed-off line to your commits automatically to help avoid DCO failures in the future.
https://github.com/etcd-io/raft/pull/451/checks?check_run_id=81293565436

Thank you!

Since Go 1.18, `any` is the built-in alias for `interface{}`. This change modernizes the codebase.

Signed-off-by: MD-Mushfiqur123 <20mahin2020@gmail.com>
@MD-Mushfiqur123 MD-Mushfiqur123 force-pushed the refactor/interface-to-any branch from 448d6ff to d3993d1 Compare June 15, 2026 10:06
@MD-Mushfiqur123

Copy link
Copy Markdown
Contributor Author

DCO fixed. Squashed to single commit with proper sign-off.

@ahrtr

ahrtr commented Jun 15, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, MD-Mushfiqur123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 39eb80a into etcd-io:main Jun 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants