Repository navigation
feat: (es_extended\server\*) tgiann inventory support - #1769
Closed
robert4049 wants to merge 21 commits into
Closed
robert4049 wants to merge 21 commits into
robert4049 wants to merge 21 commits into
Conversation
…ter) Inventory was loading before firstName and lastName were assigned to new characters when multicharacter was disabled. Fix: * Check if multicharacter is disabled (Config.Multichar) * Identify new characters (isNew) * Wait for firstName and lastName to exist * Recheck every 3 seconds Ensures identity data loads before inventory initializes
…n non-multicharacter Delay ox_inventory load until character identity is set (non-multicharacter) Inventory was loading before firstName were assigned to new characters when multicharacter was disabled. Fix/Changes: * Check if multicharacter is disabled (Config.Multichar) * Identify new characters (isNew flag) * Wait for firstName to be registered * Implement 2-minute timeout to prevent infinite loops * Log warning if registration fails to complete in time * Continue loading inventory anyway after timeout Ensures identity data loads before inventory initializes
…th timeout handling
feat(es_extended): add xPlayer.updatePlayerData
fix(es_extended): fix coordinate cmd handler arg
This PR uses the existing methods within ESX for third party inventory support to add support for TGIANN Inventory. I personally run this configuration and have not noted any issues. - [X] My commit messages and PR title follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard. - [X] My changes have been tested locally and function as expected. - [X] My PR does not introduce any breaking changes. - [X] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.
|
|
Author
|
Accidently included a bunch of commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for TGIANN inventory using the existing methodology of support for 3rd party inventories.
Motivation
I personally run TGIANN inventory and know several communities that do, adding support natively would reduce friction with upgrades.
Implementation Details
I used the exiting ox inventory bridge as a template and filled out all the applicable functions for support.
Usage Example
N/A?
PR Checklist