Skip to content

agent: Address some PR feedback #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

agent: Address some PR feedback #2304

wants to merge 1 commit into from

Conversation

jshearer
Copy link
Contributor

@jshearer jshearer commented Jul 28, 2025 •
edited
Loading

Description:

This addresses the remaining PR feedback from #2263

  • use remove() to avoid cloning in initializes_read_schema
  • simplify initial read schema discovery codepaths
  • simplify setting x-complexity-limit on inferred schemas
    • Initialize shapes with default complexity limit annotation
    • Raise complexity limit to 10,000 when sourced schemas are applied in apply_sourced_schemas

Tested this locally with a hello-world and postgres connector, confirming that their behavior is expected: hello-world has x-complexity-limit: 1000 and postgres has x-complexity-limit: 10000
Screenshot 2025-09-05 at 12 19 51
Screenshot 2025-09-05 at 12 19 33

This change is Reviewable

@jshearer jshearer marked this pull request as ready for review September 5, 2025 14:53
@jshearer jshearer marked this pull request as draft September 5, 2025 14:53
@jshearer jshearer marked this pull request as ready for review September 5, 2025 16:21
@jshearer jshearer force-pushed the jshearer/dekaf_cleanup branch from 78dfc02 to 65ccc82 Compare September 5, 2025 16:33
@jshearer
agent: Address some PR feedback
1545364 
* use remove() to avoid cloning in initializes_read_schema
* simplify initial read schema discovery codepaths
* simplify setting  on inferred schemas
  * Initialize shapes with default complexity limit annotation
  * Raise complexity limit to 10,000 when sourced schemas are applied in apply_sourced_schemas
@jshearer jshearer force-pushed the jshearer/dekaf_cleanup branch from 65ccc82 to 1545364 Compare September 5, 2025 16:36
@jshearer
Copy link
Contributor Author

jshearer commented Sep 5, 2025 •
edited
Loading

@jgraettinger I put this together a while ago and finally got around to actually testing it, and in the intervening time some other changes happened to crates/control-plane-api/src/discovers/specs.rs. I believe I resolved the conflict appropriately, but I'm just pointing that out as a place I could have misunderstood things.

Edit:
Alright nevermind, there's been more drift than I thought. Taking this back to draft

@jshearer jshearer marked this pull request as draft September 5, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraettinger jgraettinger Awaiting requested review from jgraettinger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jshearer