Include app ID in toast messages, as well as app name

[RKBoss6]

There is some confusion when updating/adding/removing apps, as sometimes the app ID can be something wildly different than the name. eg: (gallifr --> Time Traveller's Clock).
I thought it would be good if you can see both the App name that you are familiar with, and the id that appears in storage...

Toasts now will show something like:

Time Traveller's Clock (gallifr) uploaded

I also consolidated that into a reusable function that returns the string above, but if the app id and the name are the same, eg: (BackLite, backlite), just return the name.

[RKBoss6]

Btw, how would I test this? Just made code changes, but am not sure how to test this out... I tried changing the path in my fork of BangleApps in .gitmodules to my fork of AppLoaderCore, do I need to do something else as well?

[gfwilliams]

Thanks! This looks good - it really needs testing though :)

But yes, I'd have thought that changing the path in .gitmodules should do it? Or you can try and download it and run it locally as well.

[RKBoss6]

@gfwilliams I tried changing the path again, could you just pop in and check if I have done it right? https://github.com/RKBoss6/BangleApps/blob/AppLoaderUpdateTest/.gitmodules

Maybe I forgot something...

[gfwilliams]

@gfwilliams I tried changing the path again, could you just pop in and check if I have done it right? https://github.com/RKBoss6/BangleApps/blob/AppLoaderUpdateTest/.gitmodules

It looks ok to me!

https://rkboss6.github.io/BangleApps/core/js/index.js isn't the right one, but then it seems like if you're serving off master, that's not got the change in? https://github.com/RKBoss6/BangleApps/blob/master/.gitmodules

Otherwsie I'm not sure what to suggest I'm afraid

[RKBoss6]

https://rkboss6.github.io/BangleApps/core/js/index.js isn't the right one,

@gfwilliams What do you mean? Master doesn't have the changes, instead I put it on a separate branch. Should I try moving it to master?Otherwise is it possible for you to test this out, if you have a fork as well?

[gfwilliams]

Well, I assume you're serving https://rkboss6.github.io/BangleApps off of your master branch which doesn't have the changes?

If you change GitHub settings to serve off of the separate branch you have then you can test online.

And yes, I could clone your branch locally and test here, but ideally you'd do some testing yourself first.

[RKBoss6]

No, my fork is serving off of the AppLoaderUpdatesTest Branch... Still no changes, I have no idea what's happening. In the apploader core fork, I have the changes both on master and a seperate branch, so that shoulnt be an issue. Is there a setting sayinng which branch the module comes from?

[gfwilliams]

Is there a setting sayinng which branch the module comes from?

You know as much as me I'm afraid. you could try just putting your changes on your master branch and serving off that and see if it works any better?