Skip to content

lcars: fix row setting's max #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

lcars: fix row setting's max #3985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/lcars/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@
0.29: Support fastload.
0.30: Add many new colors to the settings and allows random colors on startup if enabled.
0.31: Replace degree symbol in temperature by '.
0.32: Fix settings - permit CoreT as an option for the rows.
6 changes: 3 additions & 3 deletions apps/lcars/lcars.settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var bg_code = [
'< Back': back,
'Row 1': {
value: 0 | dataOptions.indexOf(settings.dataRow1),
min: 0, max: 8,
min: 0, max: dataOptions.length - 1,
format: v => dataOptions[v],
onchange: v => {
settings.dataRow1 = dataOptions[v];
Expand All @@ -58,7 +58,7 @@ var bg_code = [
},
'Row 2': {
value: 0 | dataOptions.indexOf(settings.dataRow2),
min: 0, max: 8,
min: 0, max: dataOptions.length - 1,
format: v => dataOptions[v],
onchange: v => {
settings.dataRow2 = dataOptions[v];
Expand All @@ -67,7 +67,7 @@ var bg_code = [
},
'Row 3': {
value: 0 | dataOptions.indexOf(settings.dataRow3),
min: 0, max: 8,
min: 0, max: dataOptions.length - 1,
format: v => dataOptions[v],
onchange: v => {
settings.dataRow3 = dataOptions[v];
Expand Down
2 changes: 1 addition & 1 deletion apps/lcars/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "LCARS Clock",
"shortName":"LCARS",
"icon": "lcars.png",
"version":"0.31",
"version":"0.32",
"readme": "README.md",
"supports": ["BANGLEJS2"],
"description": "Library Computer Access Retrieval System (LCARS) clock.",
Expand Down