Skip to content

poweroff app: Use E.showMessage() instead of g.drawString(). #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025

Conversation

f-elle
Copy link
Contributor

@f-elle f-elle commented Jul 1, 2025

Changed to use E.showMessage() instead of g.drawString() to display power off message. Looks better and is more coherent.

@f-elle f-elle changed the title poweroff app: Use E.showMessage instead of g.drawString(). poweroff app: Use E.showMessage() instead of g.drawString(). Jul 1, 2025
@bobrippling
Copy link
Collaborator

Sounds good - does the main functionality still work / tested ok?

@f-elle
Copy link
Contributor Author

f-elle commented Jul 2, 2025

It was good that you asked. I tested everything myself and figured that I took away some lines of code that I shouldn't have. Fixed it and now everything works as intended.

@bobrippling
Copy link
Collaborator

Great stuff, looks good to me :)

@bobrippling bobrippling merged commit b2a54d6 into espruino:master Jul 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants