Skip to content

[Xtensa] fix duplicated CPI symbols with text section literals (LLVM-443) #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yamt
Copy link

@yamt yamt commented May 1, 2025

Description

see #112

Related

Testing

Checklist

@github-actions github-actions bot changed the title [Xtensa] fix duplicated CPI symbols with text section literals [Xtensa] fix duplicated CPI symbols with text section literals (LLVM-443) May 1, 2025
@andreisfr
Copy link
Collaborator

@yamt , thank you very much for a fix.

@andreisfr andreisfr merged commit 8de4662 into espressif:xtensa_release_19.1.2 Jul 4, 2025
5 checks passed
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA and removed Status: In Progress work is in progress labels Jul 4, 2025
@yamt
Copy link
Author

yamt commented Jul 4, 2025

@andreisfr

@yamt , thank you very much for a fix.

have you merged it and reverted it? i couldn't find it on any branches.
i'm not familiar with branch policies in this repo.

@andreisfr
Copy link
Collaborator

@andreisfr

@yamt , thank you very much for a fix.

have you merged it and reverted it? i couldn't find it on any branches. i'm not familiar with branch policies in this repo.

@yamt, I created internal MR to the release_19..1.2 with your changes. This changes will be included in next update of the xtensa_release_19.1.2 branch.

@yamt
Copy link
Author

yamt commented Jul 4, 2025

@andreisfr

@yamt , thank you very much for a fix.

have you merged it and reverted it? i couldn't find it on any branches. i'm not familiar with branch policies in this repo.

@yamt, I created internal MR to the release_19..1.2 with your changes. This changes will be included in next update of the xtensa_release_19.1.2 branch.

  • what's MR?

  • is it appropriate to file PRs against xtensa_release_19.1.2 like this PR? i happened to fix an assertion failure on the branch today and i want to submit it.

@yamt
Copy link
Author

yamt commented Jul 4, 2025

  • is it appropriate to file PRs against xtensa_release_19.1.2 like this PR? i happened to fix an assertion failure on the branch today and i want to submit it.

#114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants