feat(websocket): Add websocket HTTP redirect #771
+44
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM in general, but
we have to handle old IDFs, i.e. this component needs to work with tcp_transport component which doesnt' support redirects.
we usually do it with feature list macros, which are defined depending on IDF versions (you can check mqtt client component for example: https://github.com/espressif/esp-mqtt/blob/master/include/mqtt_supported_features.h)
glmfe
force-pushed
the
feat/add-http-redir
branch
from
d98ecab to
6afad51
Compare
glmfe
force-pushed
the
feat/add-http-redir
branch
from
6afad51 to
2613138
Compare
david-cermak
approved these changes
Feb 27, 2025
glmfe
force-pushed
the
feat/add-http-redir
branch
from
2613138 to
098f6ba
Compare
glmfe
force-pushed
the
feat/add-http-redir
branch
from
098f6ba to
72fb7bf
Compare
- Handle 301 status (moved permanently) and redirect the connection to the new host.
glmfe
force-pushed
the
feat/add-http-redir
branch
from
72fb7bf to
cd119da
Compare
| @@ -598,6 +604,23 @@ static esp_err_t esp_websocket_client_create_transport(esp_websocket_client_hand | |||
| return ESP_OK; | |||
| } | |||
|
|
|||
| static void esp_websocket_client_prepare_transport(esp_websocket_client_handle_t client) | |||
There was a problem hiding this comment.
As this is an internal function there is little reason to test for valid transport as this must be validated on user facing APIs.
The function also only set the port, I don't see the need for it.
The name is also too generic.
In summary I think this function should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description