Skip to content

Fix/mpu6050 missing "esp_driver_gpio" dependency (BSP-735) #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Open

Fix/mpu6050 missing "esp_driver_gpio" dependency (BSP-735) #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09cdef0
fix(mpu6050): add missing esp_driver_gpio to REQUIRES
tommaso-merlini Nov 5, 2025
77c58aa
fix(mpu6050): set requires with SET(REQ...)
tommaso-merlini Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/mpu6050/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
if("${IDF_VERSION_MAJOR}.${IDF_VERSION_MINOR}" VERSION_GREATER_EQUAL "5.3")
set(REQ esp_driver_gpio esp_driver_i2c)
endif()

idf_component_register(
SRCS "mpu6050.c"
INCLUDE_DIRS "include"
REQUIRES "driver"
REQUIRES driver ${REQ}
Copy link
Collaborator

@espzav espzav Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REQUIRES driver ${REQ}
REQUIRES ${REQ}

Copy link
Author

@tommaso-merlini tommaso-merlini Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added the driver in the requires and set the conditional requires, thank you for you patience.

Copy link
Collaborator

@espzav espzav Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommaso-merlini Still missing else in condition and removed driver in REQUIRES. For IDF 6 cannot be driver there. It is divided into esp_driver_gpio esp_driver_i2c

)
2 changes: 1 addition & 1 deletion components/mpu6050/idf_component.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "1.2.0"
version: "1.2.1"
description: I2C driver for MPU6050 6-axis gyroscope and accelerometer
url: https://github.com/espressif/esp-bsp/tree/master/components/mpu6050
dependencies:
Expand Down