Skip to content

fix(esp32:m5stack_atoms3) : Update pins_arduino.h of variant m5stack_atoms3 with correct LED_BUILTIN value matching GPIO #35 #11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brice-fr
Copy link

@brice-fr brice-fr commented Aug 2, 2025

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Setting the proper RGB led pin in the header code to GPIO35

Tests scenarios

I have tested my pull request on an AtomS3-Lite with Blink.ino and BlinkRGB.ino (Exemples>ESP32>GPIO>BlinkRGB)
The schematics of the AtomS3 (non-lite) shows the LED also connected to GPIO35

Related links

Fixes #11688
HW Doc for AtomS3
HW Doc for AtomS3-Lite

@brice-fr brice-fr requested a review from P-R-O-C-H-Y as a code owner August 2, 2025 20:55
@CLAassistant
Copy link

CLAassistant commented Aug 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Aug 2, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix(esp32:m5stack_atoms3/pins) : Update pins_arduino.h with correct LED_BUILTIN value":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello brice-fr, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d838aae

@brice-fr brice-fr changed the title Update pins_arduino.h of variant m5stack_atoms3 with correct LED_BUILTIN value matching GPIO #35 fix(esp32:m5stack_atoms3) : Update pins_arduino.h of variant m5stack_atoms3 with correct LED_BUILTIN value matching GPIO #35 Aug 2, 2025
@SuGlider SuGlider self-requested a review August 4, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong LED_BUILTIN definition for m5stack_atoms3 variant
2 participants